Week 375

Smart Answers

Erik left the team this week. We’ve enjoyed working with Erik and wish him all the best for the future.

New on_response block

• PR 2408 - Introduce on_response blocks to set attributes on calculator. James added this new method to allow us to consistently store question responses on an object associated with a Smart Answer. After getting favourable feedback from a spike in PR 2405, James reimplemented it and opened this PR.

Rubocop

• PR 2418 - Use auto generated Rubocop config. We were previously using govuk-lint-ruby with the --diff --cached options to prevent us from violating Rubocop rules when changing or adding code. This PR switches us to using an automatically generated configuration file to ignore existing violations. We plan to fix the ignored violations in future commits.

Fixing bugs

• PR 2391 - Restore indexable_content behaviour for outcome nodes. While not serious, this behaviour has been “broken” for quite some time so it’s great to see it fixed.

• PR 2400 - Avoid double render error if exception raised after render. James discovered this problem after Rubocop complained of some unused variables. It turns out to have been quite an edge case: the problem only occurs if an exception is raised after the response for a request has been rendered.

Documentation

James made a couple of improvements to the Smart Answers documentation:

• PR 2392 - Consistently use question mark suffix for question node keys in docs.

• PR 2393 - Documentation for the new-style testing approach.

Removing unused code

James did a bit of tidying by removing some unused code:

• PR 2402 - Remove use_legacy_data option for country_select question

• PR 2403 - Remove unused FCOEmbassyScraper

Refactoring marriage-abroad

I spent most of my time continuing to try to improve marriage-abroad.

• PR 2394 - Remove marriage-abroad outcome_os_consular_cni precalculate blocks. Move logic out of the flow and into the associated MarriageAbroadCalculator object.

• PR 2409 - Rename marriage-abroad outcomes. Consistently naming the marriage-abroad outcomes should hopefully make it clearer whether an outcome should be reused for a different purpose.

• PR 2410 - DRY up marriage-abroad same-sex ceremony-not-possible outcomes. I’ve removed one of two almost identical outcomes and asked the content team whether the change in text is valid.

Fuller set of regression tests for marriage-abroad

• PR 2395 - Add regression tests for all marriage-abroad countries. While making changes to marriage-abroad it can occasionally be useful to run regression tests for all ceremony countries (rather than for the roughly 50% we use normally). I created this PR so that we could discuss making this change permanently.

2016/17 updates for register-a-birth

• PR 2407 - Add 2016/17 rates for register-a-birth. In preparation for the start of the 2016/17 tax year on 6 April.

GFR

IR35 Tax Assurances

We received confirmation that our tax assurances for GDS are all in order.

– Chris