Chris Roos by Chris Roos

Week 350

We followed our usual pattern of Monday to Thursday on Smart Answers and Friday on GFR.

Smart Answers

Tadas did a great job of getting a number of changes out for factcheck before he headed off on holiday this week. We received feedback about a number of those changes and were able to continue working on them/get them merged in his absence:

Tadas has done a great job of working on Smart Answers over the past few months and we’ll be sad not to have him around. Good luck in the new project, Tadas.

Part Year Profit for Tax Credits

Having received the OK from HMRC, we were able to get this new Part Year Profit for Tax Credits Smart Answer merged and deployed during the week. We originally started working on this back in week 341 so it was great to finally see it go live.

The deployment was ever so slightly scary as we also had to deploy a change to url-arbiter to remove a redirect that was previously in place.

Jamie Cobbett noticed that we should also remove the redirect from short-url-manager to keep things tidy.

Handover

James and I met with David, Jenny and Mark on Monday and with David and Jenny on Thursday. We’re planning to do these at least weekly in an attempt to make the handover as seamless as possible.

We received great news during both meetings. On Monday we were given permission to convert the remaining published Smartdown flow (Calculate your leave and pay when you have a child) to have a single question per page. This makes it possible to convert this Smart Answer to Ruby without first having to add support for multiple questions per page to the Ruby implementation.

On Thursday we were given the go-ahead to archive the pay-leave-for-parents-adoption Smart Answer. James wasted no time in removing it along with another couple of unnecessary Smartdown flows.

This is great as it means that we’ll definitely be able to remove support for Smartdown flows in the relatively near future.

Pay leave for parents

I started converting pay-leave-for-parents to a single question per page and was pleasantly surprised to find that it didn’t take too long at all. I probably spent as much time converting it as I did trying to use the regression tests to give me confidence that I hadn’t broken anything. James reviewed the changes and we got them merged toward the end of the week.

We needed to make a couple of smaller supporting changes ready for this conversion: Allow smartdown flows to be rendered as text and Add QuestionPresenter#post_body.

I finished up with a work in progress pull request to add regression tests for pay-leave-for-parents

As part of the conversion to single questions per page we’re working with an analyst to determine whether or not it affects peoples use of the Smart Answer. If we find that it negatively affects people then it’ll be a strong driver to implement multiple questions per page in Ruby Smart Answers.

Other changes

I fixed a couple of failing tests that were using date specific data that changed on the 1 Oct.

James merged his changes to use Plek.new rather than Plek.current.

James merged his changes to refactor node presenters.

I merged my changes to allow us to graph flows that use next_node with a block.

GFR

James and I were joined by Tom S, Murray and Ben for our monthly drinks on Wednesday. We wandered over to The Peasant in Clerkenwell. I’d not been there before but would certainly recommend it for a post work pint.

James, Ben and I sat in the sun at Dinerama for lunch on Friday. I suspect we might not have many of these sort of days left so it’s great to get out in them while we can.

James and I spent some time going through our company Trello board on Friday afternoon. We had a number of things piling up in our triage list so it was good to discuss them and decide whether to do something about them now or to leave them until later.

James did a great job of investigating and discussing an issue opened in the Mocha project. I wonder how many other open source maintainers would go to quite the same lengths that James does in trying to understand the issues that have been reported.

We were approached by Rob Chatley during the week. Rob’s asked whether we’d be able to help out by providing a day or two of coaching for his “Software Engineering Practice” course at Imperial. We’re honoured to have been asked and it sounds like an interesting course to be involved in so we’ve agreed to help out.

Until next time, folks.

– Chris

comments powered by Disqus

Recent