Chris Roos by Chris Roos

Week 344

We were at our full complement of two for the whole week and did our usual 4:1 split of days between Smart Answers and GFR.

Smart Answers

Tadas added support for regression testing Smartdown flows before proceeding to convert student-finance-forms from Smartdown to Ruby. This is great. Thanks, Tadas!

James built on Tadas’s work by first adding regression tests for landlord-immigration-check before moving on to convert it from Smartdown to Ruby. James scripted the conversion in order to document the conversion and to leave something that may come in useful during the conversion of the two remaining Smartdown flows.

James continued to spend time working on the new part year profit calculator Smart Answer. He met with someone from HMRC on Thursday and together they managed to clear up some of the uncertainty around how it should work.

I addressed some feedback and merged my pull request to convert marriage-abroad to use ERB templates. It was great to get this final conversion merged.

I converted a few remaining test Smart Answers to use ERB templates before removing support for rendering outcomes using the YAML locale files.

I tried to make use of some analytics functionality available in a later version of the govuk_frontend_toolkit Gem.

I spent some time investigating an overlap between Rubocop rules in the styleguides and govuk-lint repositories. Having understood the situation some more I opened a pull request to replace rubocop with govuk-lint.

I deleted 25 stale branches from GitHub (all between 7 months and 2 years old). I think there’s overhead of having these lying around because it makes me wonder whether they’re important or not. Removing them means that I don’t have to think about it at all.

James and I bumped in to Rob McKinnon at GDS. Rob’s working at MoJ but is spending time at GDS to build some MoJ tools using specialist-publisher. It turns out that Rob has also used Smartdown to build an MoJ prototype in the past. I’m not sure how widespread this practice is but it’s great to hear that Rob’s pushing this sort of collaboration.

GFR

We let Neil and Brad know that we’re happy to continue working past our current contract end date. We really do want to leave this project in as good a place as possible and continuing on into at least October should help us do that.

It was good to see Tom W for lunch on Wednesday. He was in the area to meet someone else but we managed to find time for a trip to the cafe.

Our GFR day was mostly spent writing and catching up on admin, although we did make time for lunch at the recently re-opened Dinerama. Chris L joined us for food, beer and sitting in the sun. We bumped into Ben G and Tom T at too: Offset were lunching together after their office move to a new place a couple of minutes up the road.

We finished the week with a couple of pints in the sun at the Crown and Shuttle.

Until next time.

– Chris

If you have any feedback on this article, please get in touch!

Historical comments can be found here.

Recent